-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v16.9.1 proposal #40069
Merged
Merged
v16.9.1 proposal #40069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046 Fixes: #40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Notable changes: This release fixes a regression introduced by the V8 9.3 update in Node.js 16.9.0. PR-URL: #40069
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
v16.x
v8 engine
Issues and PRs related to the V8 dependency.
labels
Sep 10, 2021
cjihrig
approved these changes
Sep 10, 2021
aduh95
approved these changes
Sep 10, 2021
BethGriggs
approved these changes
Sep 10, 2021
This comment has been minimized.
This comment has been minimized.
adalinesimonian
added a commit
to adalinesimonian/jshiki
that referenced
this pull request
Sep 10, 2021
will be reverted after 16.9.1 release nodejs/node#40069 nodejs/node#40030 https://bugs.chromium.org/p/v8/issues/detail?id=12188
richardlau
added a commit
that referenced
this pull request
Sep 10, 2021
Notable changes: This release fixes a regression introduced by the V8 9.3 update in Node.js 16.9.0. PR-URL: #40069
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Sep 10, 2021
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 10, 2021
This was referenced Sep 14, 2021
targos
added
release
Issues and PRs related to Node.js releases.
and removed
build
Issues and PRs related to build files or the CI.
v8 engine
Issues and PRs related to the V8 dependency.
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
labels
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nodejs/releasers This is a quick patch release to fix #40030. As this breaks our no-releases-on-a-Friday policy I've opted to only patch the regression and not included anything else (including things already on the staging branch).
2021-09-10, Version 16.9.1 (Current), @richardlau
Notable Changes
This release fixes a regression introduced by the V8 9.3 update in Node.js 16.9.0.
Commits
04f1943109
] - deps: V8: cherry-pick 9a607043cb31 (Jiawen Geng) #40046